1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506
// Copyright 2023 The Matrix.org Foundation C.I.C.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for that specific language governing permissions and
// limitations under the License.
//! Unified API for both the Room List API and the Encryption Sync API, that
//! takes care of all the underlying details.
//!
//! This is an opiniated way to run both APIs, with high-level callbacks that
//! should be called in reaction to user actions and/or system events.
//!
//! The sync service will signal errors via its
//! [`state`](SyncService::state) that the user
//! MUST observe. Whenever an error/termination is observed, the user MUST call
//! [`SyncService::start()`] again to restart the room list sync.
use std::sync::{Arc, Mutex};
use eyeball::{SharedObservable, Subscriber};
use futures_core::Future;
use futures_util::{pin_mut, StreamExt as _};
use matrix_sdk::Client;
use thiserror::Error;
use tokio::{
sync::{
mpsc::{Receiver, Sender},
Mutex as AsyncMutex, OwnedMutexGuard,
},
task::{spawn, JoinHandle},
};
use tracing::{error, info, instrument, trace, warn, Instrument, Level};
use crate::{
encryption_sync_service::{self, EncryptionSyncPermit, EncryptionSyncService, WithLocking},
room_list_service::{self, RoomListService},
};
/// Current state of the application.
///
/// This is a high-level state indicating what's the status of the underlying
/// syncs. The application starts in `Running` mode, and then hits a terminal
/// state `Terminated` (if it gracefully exited) or `Error` (in case any of the
/// underlying syncs ran into an error).
///
/// It is the responsibility of the caller to restart the application using the
/// [`SyncService::start`] method, in case it terminated, gracefully or not.
///
/// This can be observed with [`SyncService::state`].
#[derive(Clone, Debug, PartialEq)]
pub enum State {
/// The service hasn't ever been started yet, or has been stopped.
Idle,
/// The underlying syncs are properly running in the background.
Running,
/// Any of the underlying syncs has terminated gracefully (i.e. be stopped).
Terminated,
/// Any of the underlying syncs has ran into an error.
Error,
}
pub struct SyncService {
/// Room list service used to synchronize the rooms state.
room_list_service: Arc<RoomListService>,
/// Encryption sync taking care of e2ee events.
encryption_sync_service: Arc<EncryptionSyncService>,
/// What's the state of this sync service?
state: SharedObservable<State>,
/// Use a mutex everytime to modify the `state` value, otherwise it would be
/// possible to have race conditions when starting or pausing the
/// service multiple times really quickly.
modifying_state: AsyncMutex<()>,
/// Task running the room list service.
room_list_task: Arc<Mutex<Option<JoinHandle<()>>>>,
/// Task running the encryption sync.
encryption_sync_task: Arc<Mutex<Option<JoinHandle<()>>>>,
/// Global lock to allow using at most one `EncryptionSyncService` at all
/// times.
///
/// This ensures that there's only one ever existing in the application's
/// lifetime (under the assumption that there is at most one
/// `SyncService` per application).
encryption_sync_permit: Arc<AsyncMutex<EncryptionSyncPermit>>,
/// Scheduler task ensuring proper termination.
///
/// This task is waiting for a `TerminationReport` from any of the other two
/// tasks, or from a user request via [`Self::stop()`]. It makes sure
/// that the two services are properly shut up and just interrupted.
///
/// This is set at the same time as the other two tasks.
scheduler_task: Arc<Mutex<Option<JoinHandle<()>>>>,
/// `TerminationReport` sender for the [`Self::stop()`] function.
///
/// This is set at the same time as all the tasks in [`Self::start()`].
scheduler_sender: Mutex<Option<Sender<TerminationReport>>>,
}
impl SyncService {
/// Create a new builder for configuring an `SyncService`.
pub fn builder(client: Client) -> SyncServiceBuilder {
SyncServiceBuilder::new(client)
}
/// Get the underlying `RoomListService` instance for easier access to its
/// methods.
pub fn room_list_service(&self) -> Arc<RoomListService> {
self.room_list_service.clone()
}
/// Returns the state of the sync service.
pub fn state(&self) -> Subscriber<State> {
self.state.subscribe()
}
/// The role of the scheduler task is to wait for a termination message
/// (`TerminationReport`), sent either because we wanted to stop both
/// syncs, or because one of the syncs failed (in which case we'll stop
/// the other one too).
fn spawn_scheduler_task(
&self,
mut receiver: Receiver<TerminationReport>,
) -> impl Future<Output = ()> {
let encryption_sync_task = self.encryption_sync_task.clone();
let encryption_sync = self.encryption_sync_service.clone();
let room_list_service = self.room_list_service.clone();
let room_list_task = self.room_list_task.clone();
let state = self.state.clone();
async move {
let Some(report) = receiver.recv().await else {
info!("internal channel has been closed?");
return;
};
// If one service failed, make sure to request stopping the other one.
let (stop_room_list, stop_encryption) = match &report.origin {
TerminationOrigin::EncryptionSync => (true, false),
TerminationOrigin::RoomList => (false, true),
TerminationOrigin::Scheduler => (true, true),
};
// Stop both services, and wait for the streams to properly finish: at some
// point they'll return `None` and will exit their infinite loops,
// and their tasks will gracefully terminate.
if stop_room_list {
if let Err(err) = room_list_service.stop_sync() {
warn!(?report, "unable to stop room list service: {err:#}");
}
}
{
let task = room_list_task.lock().unwrap().take();
if let Some(task) = task {
if let Err(err) = task.await {
error!("when awaiting room list service: {err:#}");
}
}
}
if stop_encryption {
if let Err(err) = encryption_sync.stop_sync() {
warn!(?report, "unable to stop encryption sync: {err:#}");
}
}
{
let task = encryption_sync_task.lock().unwrap().take();
if let Some(task) = task {
if let Err(err) = task.await {
error!("when awaiting encryption sync: {err:#}");
}
}
}
if report.is_error {
if report.has_expired {
if stop_room_list {
room_list_service.expire_sync_session().await;
}
if stop_encryption {
encryption_sync.expire_sync_session().await;
}
}
state.set(State::Error);
} else if matches!(report.origin, TerminationOrigin::Scheduler) {
state.set(State::Idle);
} else {
state.set(State::Terminated);
}
}
.instrument(tracing::span!(Level::WARN, "scheduler task"))
}
async fn encryption_sync_task(
encryption_sync: Arc<EncryptionSyncService>,
sender: Sender<TerminationReport>,
sync_permit_guard: OwnedMutexGuard<EncryptionSyncPermit>,
) {
let encryption_sync_stream = encryption_sync.sync(sync_permit_guard);
pin_mut!(encryption_sync_stream);
let (is_error, has_expired) = loop {
let res = encryption_sync_stream.next().await;
match res {
Some(Ok(())) => {
// Carry on.
}
Some(Err(err)) => {
// If the encryption sync error was an expired session, also expire the
// room list sync.
let has_expired = if let encryption_sync_service::Error::SlidingSync(err) = &err
{
err.client_api_error_kind()
== Some(&ruma::api::client::error::ErrorKind::UnknownPos)
} else {
false
};
if !has_expired {
error!("Error while processing encryption in sync service: {err:#}");
}
break (true, has_expired);
}
None => {
// The stream has ended.
break (false, false);
}
}
};
if let Err(err) = sender
.send(TerminationReport {
is_error,
has_expired,
origin: TerminationOrigin::EncryptionSync,
})
.await
{
error!("Error while sending termination report: {err:#}");
}
}
async fn room_list_sync_task(
room_list_service: Arc<RoomListService>,
sender: Sender<TerminationReport>,
) {
let room_list_stream = room_list_service.sync();
pin_mut!(room_list_stream);
let (is_error, has_expired) = loop {
let res = room_list_stream.next().await;
match res {
Some(Ok(())) => {
// Carry on.
}
Some(Err(err)) => {
// If the room list error was an expired session, also expire the
// encryption sync.
let has_expired = if let room_list_service::Error::SlidingSync(err) = &err {
err.client_api_error_kind()
== Some(&ruma::api::client::error::ErrorKind::UnknownPos)
} else {
false
};
if !has_expired {
error!("Error while processing room list in sync service: {err:#}");
}
break (true, has_expired);
}
None => {
// The stream has ended.
break (false, false);
}
}
};
if let Err(err) = sender
.send(TerminationReport { is_error, has_expired, origin: TerminationOrigin::RoomList })
.await
{
error!("Error while sending termination report: {err:#}");
}
}
/// Start (or restart) the underlying sliding syncs.
///
/// This can be called multiple times safely:
/// - if the stream is still properly running, it won't be restarted.
/// - if the stream has been aborted before, it will be properly cleaned up
/// and restarted.
pub async fn start(&self) {
let _guard = self.modifying_state.lock().await;
// Only (re)start the tasks if any was stopped.
if matches!(self.state.get(), State::Running) {
// It was already true, so we can skip the restart.
return;
}
trace!("starting sync service");
let (sender, receiver) = tokio::sync::mpsc::channel(16);
// First, take care of the room list.
*self.room_list_task.lock().unwrap() =
Some(spawn(Self::room_list_sync_task(self.room_list_service.clone(), sender.clone())));
// Then, take care of the encryption sync.
let sync_permit_guard = self.encryption_sync_permit.clone().lock_owned().await;
*self.encryption_sync_task.lock().unwrap() = Some(spawn(Self::encryption_sync_task(
self.encryption_sync_service.clone(),
sender.clone(),
sync_permit_guard,
)));
// Spawn the scheduler task.
*self.scheduler_sender.lock().unwrap() = Some(sender);
*self.scheduler_task.lock().unwrap() = Some(spawn(self.spawn_scheduler_task(receiver)));
self.state.set(State::Running);
}
/// Stop the underlying sliding syncs.
///
/// This must be called when the app goes into the background. It's better
/// to call this API when the application exits, although not strictly
/// necessary.
#[instrument(skip_all)]
pub async fn stop(&self) -> Result<(), Error> {
let _guard = self.modifying_state.lock().await;
match self.state.get() {
State::Idle | State::Terminated | State::Error => {
// No need to stop if we were not running.
return Ok(());
}
State::Running => {}
};
trace!("pausing sync service");
// First, request to stop the two underlying syncs; we'll look at the results
// later, so that we're in a clean state independently of the request to
// stop.
let sender = self.scheduler_sender.lock().unwrap().clone();
sender
.ok_or_else(|| {
error!("missing sender");
Error::InternalSchedulerError
})?
.send(TerminationReport {
is_error: false,
has_expired: false,
origin: TerminationOrigin::Scheduler,
})
.await
.map_err(|err| {
error!("when sending termination report: {err}");
Error::InternalSchedulerError
})?;
let scheduler_task = self.scheduler_task.lock().unwrap().take();
scheduler_task
.ok_or_else(|| {
error!("missing scheduler task");
Error::InternalSchedulerError
})?
.await
.map_err(|err| {
error!("couldn't finish scheduler task: {err}");
Error::InternalSchedulerError
})?;
Ok(())
}
/// Attempt to get a permit to use an `EncryptionSyncService` at a given
/// time.
///
/// This ensures there is at most one [`EncryptionSyncService`] active at
/// any time, per application.
pub fn try_get_encryption_sync_permit(&self) -> Option<OwnedMutexGuard<EncryptionSyncPermit>> {
self.encryption_sync_permit.clone().try_lock_owned().ok()
}
}
#[derive(Debug)]
enum TerminationOrigin {
EncryptionSync,
RoomList,
Scheduler,
}
#[derive(Debug)]
struct TerminationReport {
is_error: bool,
has_expired: bool,
origin: TerminationOrigin,
}
// Testing helpers, mostly.
#[doc(hidden)]
impl SyncService {
/// Return the existential states of internal tasks.
pub fn task_states(&self) -> (bool, bool) {
(
self.encryption_sync_task.lock().unwrap().is_some(),
self.room_list_task.lock().unwrap().is_some(),
)
}
}
#[derive(Clone)]
pub struct SyncServiceBuilder {
/// SDK client.
client: Client,
/// Is the cross-process lock for the crypto store enabled?
with_cross_process_lock: bool,
}
impl SyncServiceBuilder {
fn new(client: Client) -> Self {
Self { client, with_cross_process_lock: false }
}
/// Enables the cross-process lock, if the sync service is being built in a
/// multi-process setup.
///
/// It's a prerequisite if another process can *also* process encryption
/// events. This is only applicable to very specific use cases, like an
/// external process attempting to decrypt notifications. In general,
/// `with_cross_process_lock` should not be called.
///
/// Be sure to have configured
/// [`Client::cross_process_store_locks_holder_name`] accordingly.
pub fn with_cross_process_lock(mut self) -> Self {
self.with_cross_process_lock = true;
self
}
/// Finish setting up the `SyncService`.
///
/// This creates the underlying sliding syncs, and will *not* start them in
/// the background. The resulting `SyncService` must be kept alive as
/// long as the sliding syncs are supposed to run.
pub async fn build(self) -> Result<SyncService, Error> {
let encryption_sync_permit = Arc::new(AsyncMutex::new(EncryptionSyncPermit::new()));
let room_list = RoomListService::new(self.client.clone()).await?;
let encryption_sync = Arc::new(
EncryptionSyncService::new(
self.client,
None,
WithLocking::from(self.with_cross_process_lock),
)
.await?,
);
Ok(SyncService {
room_list_service: Arc::new(room_list),
encryption_sync_service: encryption_sync,
encryption_sync_task: Arc::new(Mutex::new(None)),
room_list_task: Arc::new(Mutex::new(None)),
scheduler_task: Arc::new(Mutex::new(None)),
scheduler_sender: Mutex::new(None),
state: SharedObservable::new(State::Idle),
modifying_state: AsyncMutex::new(()),
encryption_sync_permit,
})
}
}
/// Errors for the `SyncService` API.
#[derive(Debug, Error)]
pub enum Error {
/// An error received from the `RoomListService` API.
#[error(transparent)]
RoomList(#[from] room_list_service::Error),
/// An error received from the `EncryptionSyncService` API.
#[error(transparent)]
EncryptionSync(#[from] encryption_sync_service::Error),
#[error("the scheduler channel has run into an unexpected error")]
InternalSchedulerError,
}