1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615
// Copyright 2023 The Matrix.org Foundation C.I.C.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for that specific language governing permissions and
// limitations under the License.
//! `RoomListService` API.
//!
//! The `RoomListService` is a UI API dedicated to present a list of Matrix
//! rooms to the user. The syncing is handled by [`SlidingSync`]. The idea is to
//! expose a simple API to handle most of the client app use cases, like:
//! Showing and updating a list of rooms, filtering a list of rooms, handling
//! particular updates of a range of rooms (the ones the client app is showing
//! to the view, i.e. the rooms present in the viewport) etc.
//!
//! As such, the `RoomListService` works as an opinionated state machine. The
//! states are defined by [`State`]. Actions are attached to the each state
//! transition.
//!
//! The API is purposely small. Sliding Sync is versatile. `RoomListService` is
//! _one_ specific usage of Sliding Sync.
//!
//! # Basic principle
//!
//! `RoomListService` works with 1 Sliding Sync List:
//!
//! * `all_rooms` (referred by the constant [`ALL_ROOMS_LIST_NAME`]) is the only
//! list. Its goal is to load all the user' rooms. It starts with a
//! [`SlidingSyncMode::Selective`] sync-mode with a small range (i.e. a small
//! set of rooms) to load the first rooms quickly, and then updates to a
//! [`SlidingSyncMode::Growing`] sync-mode to load the remaining rooms “in the
//! background”: it will sync the existing rooms and will fetch new rooms, by
//! a certain batch size.
//!
//! This behavior has proven to be empirically satisfying to provide a fast and
//! fluid user experience for a Matrix client.
//!
//! [`RoomListService::all_rooms`] provides a way to get a [`RoomList`] for all
//! the rooms. From that, calling [`RoomList::entries_with_dynamic_adapters`]
//! provides a way to get a stream of rooms. This stream is sorted, can be
//! filtered, and the filter can be changed over time.
//!
//! [`RoomListService::state`] provides a way to get a stream of the state
//! machine's state, which can be pretty helpful for the client app.
pub mod filters;
mod room;
mod room_list;
pub mod sorters;
mod state;
use std::{sync::Arc, time::Duration};
use async_stream::stream;
use eyeball::Subscriber;
use futures_util::{pin_mut, Stream, StreamExt};
use matrix_sdk::{
event_cache::EventCacheError, Client, Error as SlidingSyncError, SlidingSync, SlidingSyncList,
SlidingSyncMode,
};
use matrix_sdk_base::sliding_sync::http;
pub use room::*;
pub use room_list::*;
use ruma::{assign, directory::RoomTypeFilter, events::StateEventType, OwnedRoomId, RoomId, UInt};
pub use state::*;
use thiserror::Error;
use tokio::time::timeout;
use tracing::debug;
use crate::timeline;
/// The default `required_state` constant value for sliding sync lists and
/// sliding sync room subscriptions.
const DEFAULT_REQUIRED_STATE: &[(StateEventType, &str)] = &[
(StateEventType::RoomName, ""),
(StateEventType::RoomEncryption, ""),
(StateEventType::RoomMember, "$LAZY"),
(StateEventType::RoomMember, "$ME"),
(StateEventType::RoomTopic, ""),
(StateEventType::RoomCanonicalAlias, ""),
(StateEventType::RoomPowerLevels, ""),
(StateEventType::CallMember, "*"),
(StateEventType::RoomJoinRules, ""),
];
/// The default `required_state` constant value for sliding sync room
/// subscriptions that must be added to `DEFAULT_REQUIRED_STATE`.
const DEFAULT_ROOM_SUBSCRIPTION_EXTRA_REQUIRED_STATE: &[(StateEventType, &str)] =
&[(StateEventType::RoomCreate, ""), (StateEventType::RoomPinnedEvents, "")];
/// The default `timeline_limit` value when used with room subscriptions.
const DEFAULT_ROOM_SUBSCRIPTION_TIMELINE_LIMIT: u32 = 20;
/// The [`RoomListService`] type. See the module's documentation to learn more.
#[derive(Debug)]
pub struct RoomListService {
/// Client that has created this [`RoomListService`].
client: Client,
/// The Sliding Sync instance.
sliding_sync: Arc<SlidingSync>,
/// The current state of the `RoomListService`.
///
/// `RoomListService` is a simple state-machine.
state_machine: StateMachine,
}
impl RoomListService {
/// Create a new `RoomList`.
///
/// A [`matrix_sdk::SlidingSync`] client will be created, with a cached list
/// already pre-configured.
///
/// This won't start an encryption sync, and it's the user's responsibility
/// to create one in this case using
/// [`EncryptionSyncService`][crate::encryption_sync_service::EncryptionSyncService].
pub async fn new(client: Client) -> Result<Self, Error> {
let builder = client
.sliding_sync("room-list")
.map_err(Error::SlidingSync)?
.with_account_data_extension(
assign!(http::request::AccountData::default(), { enabled: Some(true) }),
)
.with_receipt_extension(assign!(http::request::Receipts::default(), {
enabled: Some(true),
rooms: Some(vec![http::request::ReceiptsRoom::AllSubscribed])
}))
.with_typing_extension(assign!(http::request::Typing::default(), {
enabled: Some(true),
}));
// TODO: Re-enable once we know it creates slowness.
// // We don't deal with encryption device messages here so this is safe
// .share_pos();
let sliding_sync = builder
.add_cached_list(
SlidingSyncList::builder(ALL_ROOMS_LIST_NAME)
.sync_mode(
SlidingSyncMode::new_selective()
.add_range(ALL_ROOMS_DEFAULT_SELECTIVE_RANGE),
)
.timeline_limit(1)
.required_state(
DEFAULT_REQUIRED_STATE
.iter()
.map(|(state_event, value)| (state_event.clone(), (*value).to_owned()))
.collect(),
)
.include_heroes(Some(true))
.filters(Some(assign!(http::request::ListFilters::default(), {
// As defined in the [SlidingSync MSC](https://github.com/matrix-org/matrix-spec-proposals/blob/9450ced7fb9cf5ea9077d029b3adf36aebfa8709/proposals/3575-sync.md?plain=1#L444)
// If unset, both invited and joined rooms are returned. If false, no invited rooms are
// returned. If true, only invited rooms are returned.
is_invite: None,
not_room_types: vec![RoomTypeFilter::Space],
}))),
)
.await
.map_err(Error::SlidingSync)?
.build()
.await
.map(Arc::new)
.map_err(Error::SlidingSync)?;
// Eagerly subscribe the event cache to sync responses.
client.event_cache().subscribe()?;
Ok(Self { client, sliding_sync, state_machine: StateMachine::new() })
}
/// Start to sync the room list.
///
/// It's the main method of this entire API. Calling `sync` allows to
/// receive updates on the room list: new rooms, rooms updates etc. Those
/// updates can be read with [`RoomList::entries`] for example. This method
/// returns a [`Stream`] where produced items only hold an empty value
/// in case of a sync success, otherwise an error.
///
/// The `RoomListService`' state machine is run by this method.
///
/// Stopping the [`Stream`] (i.e. by calling [`Self::stop_sync`]), and
/// calling [`Self::sync`] again will resume from the previous state of
/// the state machine.
///
/// This should be used only for testing. In practice, most users should be
/// using the [`SyncService`] instead.
#[doc(hidden)]
pub fn sync(&self) -> impl Stream<Item = Result<(), Error>> + '_ {
stream! {
let sync = self.sliding_sync.sync();
pin_mut!(sync);
// This is a state machine implementation.
// Things happen in this order:
//
// 1. The next state is calculated,
// 2. The actions associated to the next state are run,
// 3. A sync is done,
// 4. The next state is stored.
loop {
debug!("Run a sync iteration");
// Calculate the next state, and run the associated actions.
let next_state = self.state_machine.next(&self.sliding_sync).await?;
// Do the sync.
match sync.next().await {
// Got a successful result while syncing.
Some(Ok(_update_summary)) => {
debug!(state = ?next_state, "New state");
// Update the state.
self.state_machine.set(next_state);
yield Ok(());
}
// Got an error while syncing.
Some(Err(error)) => {
debug!(expected_state = ?next_state, "New state is an error");
let next_state = State::Error { from: Box::new(next_state) };
self.state_machine.set(next_state);
yield Err(Error::SlidingSync(error));
break;
}
// Sync loop has terminated.
None => {
debug!(expected_state = ?next_state, "New state is a termination");
let next_state = State::Terminated { from: Box::new(next_state) };
self.state_machine.set(next_state);
break;
}
}
}
}
}
/// Force to stop the sync of the `RoomListService` started by
/// [`Self::sync`].
///
/// It's of utter importance to call this method rather than stop polling
/// the `Stream` returned by [`Self::sync`] because it will force the
/// cancellation and exit the sync loop, i.e. it will cancel any
/// in-flight HTTP requests, cancel any pending futures etc. and put the
/// service into a termination state.
///
/// Ideally, one wants to consume the `Stream` returned by [`Self::sync`]
/// until it returns `None`, because of [`Self::stop_sync`], so that it
/// ensures the states are correctly placed.
///
/// Stopping the sync of the room list via this method will put the
/// state-machine into the [`State::Terminated`] state.
///
/// This should be used only for testing. In practice, most users should be
/// using the [`SyncService`] instead.
#[doc(hidden)]
pub fn stop_sync(&self) -> Result<(), Error> {
self.sliding_sync.stop_sync().map_err(Error::SlidingSync)
}
/// Force the sliding sync session to expire.
///
/// This is used by [`SyncService`][crate::SyncService].
///
/// **Warning**: This method **must not** be called while the sync loop is
/// running!
pub(crate) async fn expire_sync_session(&self) {
self.sliding_sync.expire_session().await;
// Usually, when the session expires, it leads the state to be `Error`,
// thus some actions (like refreshing the lists) are executed. However,
// if the sync loop has been stopped manually, the state is `Terminated`, and
// when the session is forced to expire, the state remains `Terminated`, thus
// the actions aren't executed as expected. Consequently, let's update the
// state.
if let State::Terminated { from } = self.state_machine.get() {
self.state_machine.set(State::Error { from });
}
}
/// Get a [`Stream`] of [`SyncIndicator`].
///
/// Read the documentation of [`SyncIndicator`] to learn more about it.
pub fn sync_indicator(
&self,
delay_before_showing: Duration,
delay_before_hiding: Duration,
) -> impl Stream<Item = SyncIndicator> {
let mut state = self.state();
stream! {
// Ensure the `SyncIndicator` is always hidden to start with.
yield SyncIndicator::Hide;
// Let's not wait for an update to happen. The `SyncIndicator` must be
// computed as fast as possible.
let mut current_state = state.next_now();
loop {
let (sync_indicator, yield_delay) = match current_state {
State::Init | State::Error { .. } => {
(SyncIndicator::Show, delay_before_showing)
}
State::SettingUp | State::Recovering | State::Running | State::Terminated { .. } => {
(SyncIndicator::Hide, delay_before_hiding)
}
};
// `state.next().await` has a maximum of `yield_delay` time to execute…
let next_state = match timeout(yield_delay, state.next()).await {
// A new state has been received before `yield_delay` time. The new
// `sync_indicator` value won't be yielded.
Ok(next_state) => next_state,
// No new state has been received before `yield_delay` time. The
// `sync_indicator` value can be yielded.
Err(_) => {
yield sync_indicator;
// Now that `sync_indicator` has been yielded, let's wait on
// the next state again.
state.next().await
}
};
if let Some(next_state) = next_state {
// Update the `current_state`.
current_state = next_state;
} else {
// Something is broken with the state. Let's stop this stream too.
break;
}
}
}
}
/// Get the [`Client`] that has been used to create [`Self`].
pub fn client(&self) -> &Client {
&self.client
}
/// Get a subscriber to the state.
pub fn state(&self) -> Subscriber<State> {
self.state_machine.subscribe()
}
async fn list_for(&self, sliding_sync_list_name: &str) -> Result<RoomList, Error> {
RoomList::new(&self.client, &self.sliding_sync, sliding_sync_list_name, self.state()).await
}
/// Get a [`RoomList`] for all rooms.
pub async fn all_rooms(&self) -> Result<RoomList, Error> {
self.list_for(ALL_ROOMS_LIST_NAME).await
}
/// Get a [`Room`] if it exists.
pub fn room(&self, room_id: &RoomId) -> Result<Room, Error> {
Ok(Room::new(
self.client.get_room(room_id).ok_or_else(|| Error::RoomNotFound(room_id.to_owned()))?,
&self.sliding_sync,
))
}
/// Subscribe to rooms.
///
/// It means that all events from these rooms will be received every time,
/// no matter how the `RoomList` is configured.
pub fn subscribe_to_rooms(&self, room_ids: &[&RoomId]) {
let settings = assign!(http::request::RoomSubscription::default(), {
required_state: DEFAULT_REQUIRED_STATE.iter().map(|(state_event, value)| {
(state_event.clone(), (*value).to_owned())
})
.chain(
DEFAULT_ROOM_SUBSCRIPTION_EXTRA_REQUIRED_STATE.iter().map(|(state_event, value)| {
(state_event.clone(), (*value).to_owned())
})
)
.collect(),
timeline_limit: UInt::from(DEFAULT_ROOM_SUBSCRIPTION_TIMELINE_LIMIT),
});
let cancel_in_flight_request = match self.state_machine.get() {
State::Init | State::Recovering | State::Error { .. } | State::Terminated { .. } => {
false
}
State::SettingUp | State::Running => true,
};
self.sliding_sync.subscribe_to_rooms(room_ids, Some(settings), cancel_in_flight_request)
}
#[cfg(test)]
pub fn sliding_sync(&self) -> &SlidingSync {
&self.sliding_sync
}
}
/// [`RoomList`]'s errors.
#[derive(Debug, Error)]
pub enum Error {
/// Error from [`matrix_sdk::SlidingSync`].
#[error(transparent)]
SlidingSync(SlidingSyncError),
/// An operation has been requested on an unknown list.
#[error("Unknown list `{0}`")]
UnknownList(String),
/// The requested room doesn't exist.
#[error("Room `{0}` not found")]
RoomNotFound(OwnedRoomId),
#[error("A timeline instance already exists for room {0}")]
TimelineAlreadyExists(OwnedRoomId),
#[error(transparent)]
InitializingTimeline(#[from] timeline::Error),
#[error(transparent)]
EventCache(#[from] EventCacheError),
}
/// An hint whether a _sync spinner/loader/toaster_ should be prompted to the
/// user, indicating that the [`RoomListService`] is syncing.
///
/// This is entirely arbitrary and optinionated. Of course, once
/// [`RoomListService::sync`] has been called, it's going to be constantly
/// syncing, until [`RoomListService::stop_sync`] is called, or until an error
/// happened. But in some cases, it's better for the user experience to prompt
/// to the user that a sync is happening. It's usually the first sync, or the
/// recovering sync. However, the sync indicator must be prompted if the
/// aforementioned sync is “slow”, otherwise the indicator is likely to “blink”
/// pretty fast, which can be very confusing. It's also common to indicate to
/// the user that a syncing is happening in case of a network error, that
/// something is catching up etc.
#[derive(Debug, Eq, PartialEq)]
pub enum SyncIndicator {
/// Show the sync indicator.
Show,
/// Hide the sync indicator.
Hide,
}
#[cfg(test)]
mod tests {
use std::future::ready;
use assert_matches::assert_matches;
use futures_util::{pin_mut, StreamExt};
use matrix_sdk::{
config::RequestConfig,
matrix_auth::{MatrixSession, MatrixSessionTokens},
reqwest::Url,
sliding_sync::Version as SlidingSyncVersion,
Client, SlidingSyncMode,
};
use matrix_sdk_base::SessionMeta;
use matrix_sdk_test::async_test;
use ruma::{api::MatrixVersion, device_id, user_id};
use serde_json::json;
use wiremock::{http::Method, Match, Mock, MockServer, Request, ResponseTemplate};
use super::{Error, RoomListService, State, ALL_ROOMS_LIST_NAME};
async fn new_client() -> (Client, MockServer) {
let session = MatrixSession {
meta: SessionMeta {
user_id: user_id!("@example:localhost").to_owned(),
device_id: device_id!("DEVICEID").to_owned(),
},
tokens: MatrixSessionTokens { access_token: "1234".to_owned(), refresh_token: None },
};
let server = MockServer::start().await;
let client = Client::builder()
.homeserver_url(server.uri())
.server_versions([MatrixVersion::V1_0])
.request_config(RequestConfig::new().disable_retry())
.build()
.await
.unwrap();
client.restore_session(session).await.unwrap();
(client, server)
}
pub(super) async fn new_room_list() -> Result<RoomListService, Error> {
let (client, _) = new_client().await;
RoomListService::new(client).await
}
struct SlidingSyncMatcher;
impl Match for SlidingSyncMatcher {
fn matches(&self, request: &Request) -> bool {
request.url.path() == "/_matrix/client/unstable/org.matrix.simplified_msc3575/sync"
&& request.method == Method::POST
}
}
#[async_test]
async fn test_sliding_sync_proxy_url() -> Result<(), Error> {
let (client, _) = new_client().await;
{
let room_list = RoomListService::new(client.clone()).await?;
assert_matches!(room_list.sliding_sync().version(), SlidingSyncVersion::Native);
}
{
let url = Url::parse("https://foo.matrix/").unwrap();
client.set_sliding_sync_version(SlidingSyncVersion::Proxy { url: url.clone() });
let room_list = RoomListService::new(client.clone()).await?;
assert_matches!(
room_list.sliding_sync().version(),
SlidingSyncVersion::Proxy { url: given_url } => {
assert_eq!(&url, given_url);
}
);
}
Ok(())
}
#[async_test]
async fn test_all_rooms_are_declared() -> Result<(), Error> {
let room_list = new_room_list().await?;
let sliding_sync = room_list.sliding_sync();
// List is present, in Selective mode.
assert_eq!(
sliding_sync
.on_list(ALL_ROOMS_LIST_NAME, |list| ready(matches!(
list.sync_mode(),
SlidingSyncMode::Selective { ranges } if ranges == vec![0..=19]
)))
.await,
Some(true)
);
Ok(())
}
#[async_test]
async fn test_expire_sliding_sync_session_manually() -> Result<(), Error> {
let (client, server) = new_client().await;
let room_list = RoomListService::new(client).await?;
let sync = room_list.sync();
pin_mut!(sync);
// Run a first sync.
{
let _mock_guard = Mock::given(SlidingSyncMatcher)
.respond_with(move |_request: &Request| {
ResponseTemplate::new(200).set_body_json(json!({
"pos": "0",
"lists": {
ALL_ROOMS_LIST_NAME: {
"count": 0,
"ops": [],
},
},
"rooms": {},
}))
})
.mount_as_scoped(&server)
.await;
let _ = sync.next().await;
}
assert_eq!(room_list.state().get(), State::SettingUp);
// Stop the sync.
room_list.stop_sync()?;
// Do another sync.
let _ = sync.next().await;
// State is `Terminated`, as expected!
assert_eq!(
room_list.state_machine.get(),
State::Terminated { from: Box::new(State::Running) }
);
// Now, let's make the sliding sync session to expire.
room_list.expire_sync_session().await;
// State is `Error`, as a regular session expiration would generate!
assert_eq!(room_list.state_machine.get(), State::Error { from: Box::new(State::Running) });
Ok(())
}
}