1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106
// Copyright 2024 The Matrix.org Foundation C.I.C.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
use ruma::UserId;
use tracing::error;
use vodozemac::Curve25519PublicKey;
use super::{InboundGroupSession, KnownSenderData, SenderData};
use crate::{
error::MismatchedIdentityKeysError, store::Store, types::events::olm_v1::DecryptedRoomKeyEvent,
CryptoStoreError, Device, DeviceData, MegolmError, OlmError, SignatureError,
};
/// Temporary struct that is used to look up [`SenderData`] based on the
/// information supplied in
/// [`crate::types::events::olm_v1::DecryptedRoomKeyEvent`].
///
/// # Algorithm
///
/// When we receive a to-device message establishing a megolm session (i.e. when
/// [`crate::machine::OlmMachine::add_room_key`] is called):
///
/// ┌───────────────────────────────────────────────────────────────────┐
/// │ A (start - we have a to-device message containing a room key) │
/// └───────────────────────────────────────────────────────────────────┘
/// │
/// __________________________________▼______________________________
/// ╱ ╲
/// ╱ Does the to-device message contain the device_keys property from ╲yes
/// ╲ MSC4147? ╱ │
/// ╲_________________________________________________________________╱ │
/// │ no │
/// ▼ │
/// ┌───────────────────────────────────────────────────────────────────┐ │
/// │ B (there are no device keys in the to-device message) │ │
/// │ │ │
/// │ We need to find the device details. │ │
/// └───────────────────────────────────────────────────────────────────┘ │
/// │ │
/// __________________________________▼______________________________ │
/// ╱ ╲ │
/// ╱ Does the store contain a device whose curve key matches the ╲ ▼
/// ╲ sender of the to-device message? ╱yes
/// ╲_________________________________________________________________╱ │
/// │ no │
/// ▼ │
/// ╭───────────────────────────────────────────────────────────────────╮ │
/// │ C (we don't know the sending device) │ │
/// │ │ │
/// │ Give up: we have no sender info for this room key. │ │
/// ╰───────────────────────────────────────────────────────────────────╯ │
/// ┌─────────────────────────────────┘
/// ▼
/// ┌───────────────────────────────────────────────────────────────────┐
/// │ D (we have the device) │
/// └───────────────────────────────────────────────────────────────────┘
/// │
/// __________________________________▼______________________________
/// ╱ ╲
/// ╱ Is the session owned by the device? ╲yes
/// ╲___________________________________________________________________╱ │
/// │ no │
/// ▼ │
/// ╭───────────────────────────────────────────────────────────────────╮ │
/// │ E (the device does not own the session) │ │
/// │ │ │
/// │ Give up: something is wrong with the session. │ │
/// ╰───────────────────────────────────────────────────────────────────╯ │
/// ┌─────────────────────────────────┘
/// __________________________________▼______________________________
/// ╱ ╲
/// ╱ Is the device cross-signed by the sender? ╲yes
/// ╲___________________________________________________________________╱ │
/// │ no │
/// ▼ │
/// ┌───────────────────────────────────────────────────────────────────┐ │
/// │ F (we have device keys, but they are not signed by the sender) │ │
/// │ │ │
/// │ Store the device with the session, in case we can confirm it │ │
/// │ later. │ │
/// ╰───────────────────────────────────────────────────────────────────╯ │
/// ┌─────────────────────────────────┘
/// ▼
/// ┌───────────────────────────────────────────────────────────────────┐
/// │ G (device is cross-signed by the sender) │
/// └───────────────────────────────────────────────────────────────────┘
/// │
/// __________________________________▼______________________________
/// ╱ ╲
/// ╱ Does the cross-signing key match that used ╲yes
/// ╲ to sign the device? ╱ │
/// ╲_________________________________________________________________╱ │
/// │ no │
/// ▼ │
/// ╭───────────────────────────────────────────────────────────────────╮ │
/// │ Store the device with the session, in case we get the │ │
/// │ right cross-signing key later. │ │
/// ╰───────────────────────────────────────────────────────────────────╯ │
/// ┌─────────────────────────────────┘
/// ▼
/// ┌───────────────────────────────────────────────────────────────────┐
/// │ H (cross-signing key matches that used to sign the device!) │
/// │ │
/// │ Look up the user_id and master_key for the user sending the │
/// │ to-device message. │
/// │ │
/// │ Decide the master_key trust level based on whether we have │
/// │ verified this user. │
/// │ │
/// │ Store this information with the session. │
/// ╰───────────────────────────────────────────────────────────────────╯
///
/// Note: the sender data may become out-of-date if we later verify the user. We
/// have no plans to update it if so.
pub(crate) struct SenderDataFinder<'a> {
store: &'a Store,
session: &'a InboundGroupSession,
}
impl<'a> SenderDataFinder<'a> {
/// Find the device associated with the to-device message used to
/// create the InboundGroupSession we are about to create, and decide
/// whether we trust the sender.
pub(crate) async fn find_using_event(
store: &'a Store,
sender_curve_key: Curve25519PublicKey,
room_key_event: &'a DecryptedRoomKeyEvent,
session: &'a InboundGroupSession,
) -> Result<SenderData, SessionDeviceKeysCheckError> {
let finder = Self { store, session };
finder.have_event(sender_curve_key, room_key_event).await
}
/// Use the supplied device data to decide whether we trust the sender.
pub(crate) async fn find_using_device_data(
store: &'a Store,
device_data: DeviceData,
session: &'a InboundGroupSession,
) -> Result<SenderData, SessionDeviceCheckError> {
let finder = Self { store, session };
finder.have_device_data(device_data).await
}
/// Find the device using the curve key provided, and decide whether we
/// trust the sender.
pub(crate) async fn find_using_curve_key(
store: &'a Store,
sender_curve_key: Curve25519PublicKey,
sender_user_id: &'a UserId,
session: &'a InboundGroupSession,
) -> Result<SenderData, SessionDeviceCheckError> {
let finder = Self { store, session };
finder.search_for_device(sender_curve_key, sender_user_id).await
}
/// Step A (start - we have a to-device message containing a room key)
async fn have_event(
&self,
sender_curve_key: Curve25519PublicKey,
room_key_event: &'a DecryptedRoomKeyEvent,
) -> Result<SenderData, SessionDeviceKeysCheckError> {
// Does the to-device message contain the device_keys property from MSC4147?
if let Some(sender_device_keys) = &room_key_event.device_keys {
// Yes: use the device keys to continue.
// Validate the signature of the DeviceKeys supplied.
let sender_device_data = DeviceData::try_from(sender_device_keys)?;
Ok(self.have_device_data(sender_device_data).await?)
} else {
// No: look for the device in the store
Ok(self.search_for_device(sender_curve_key, &room_key_event.sender).await?)
}
}
/// Step B (there are no device keys in the to-device message)
async fn search_for_device(
&self,
sender_curve_key: Curve25519PublicKey,
sender_user_id: &UserId,
) -> Result<SenderData, SessionDeviceCheckError> {
// Does the locally-cached (in the store) devices list contain a device with the
// curve key of the sender of the to-device message?
if let Some(sender_device) =
self.store.get_device_from_curve_key(sender_user_id, sender_curve_key).await?
{
// Yes: use the device to continue
self.have_device(sender_device)
} else {
// Step C (we don't know the sending device)
//
// We have no device data for this session so we can't continue in the "fast
// lane" (blocking sync).
let sender_data = SenderData::UnknownDevice {
// This is not a legacy session since we did attempt to look
// up its sender data at the time of reception.
legacy_session: false,
owner_check_failed: false,
};
Ok(sender_data)
}
}
async fn have_device_data(
&self,
sender_device_data: DeviceData,
) -> Result<SenderData, SessionDeviceCheckError> {
let sender_device = self.store.wrap_device_data(sender_device_data).await?;
self.have_device(sender_device)
}
/// Step D (we have a device)
///
/// Returns Err if the device does not own the session.
fn have_device(&self, sender_device: Device) -> Result<SenderData, SessionDeviceCheckError> {
// Is the session owned by the device?
let device_is_owner = sender_device.is_owner_of_session(self.session)?;
// Is the device cross-signed?
// Does the cross-signing key match that used to sign the device?
// And is the signature in the device valid?
let cross_signed = sender_device.is_cross_signed_by_owner();
Ok(match (device_is_owner, cross_signed) {
(true, true) => self.device_is_cross_signed_by_sender(sender_device),
(true, false) => {
// F (we have device keys, but they are not signed by the sender)
SenderData::device_info(sender_device.as_device_keys().clone())
}
(false, _) => {
// Step E (the device does not own the session)
// Give up: something is wrong with the session.
SenderData::UnknownDevice { legacy_session: false, owner_check_failed: true }
}
})
}
/// Step G (device is cross-signed by the sender)
fn device_is_cross_signed_by_sender(&self, sender_device: Device) -> SenderData {
// H (cross-signing key matches that used to sign the device!)
let user_id = sender_device.user_id().to_owned();
let device_id = Some(sender_device.device_id().to_owned());
let master_key = sender_device
.device_owner_identity
.as_ref()
.and_then(|i| i.master_key().get_first_key());
if let Some(master_key) = master_key {
// We have user_id and master_key for the user sending the to-device message.
let master_key = Box::new(master_key);
let known_sender_data = KnownSenderData { user_id, device_id, master_key };
if sender_device.is_cross_signing_trusted() {
SenderData::SenderVerified(known_sender_data)
} else if sender_device
.device_owner_identity
.expect("User with master key must have identity")
.was_previously_verified()
{
SenderData::VerificationViolation(known_sender_data)
} else {
SenderData::SenderUnverified(known_sender_data)
}
} else {
// Surprisingly, there was no key in the MasterPubkey. We did not expect this:
// treat it as if the device was not signed by this master key.
//
error!("MasterPubkey for user {user_id} does not contain any keys!",);
SenderData::device_info(sender_device.as_device_keys().clone())
}
}
}
#[derive(Debug)]
pub(crate) enum SessionDeviceCheckError {
CryptoStoreError(CryptoStoreError),
MismatchedIdentityKeys(MismatchedIdentityKeysError),
}
impl From<CryptoStoreError> for SessionDeviceCheckError {
fn from(e: CryptoStoreError) -> Self {
Self::CryptoStoreError(e)
}
}
impl From<MismatchedIdentityKeysError> for SessionDeviceCheckError {
fn from(e: MismatchedIdentityKeysError) -> Self {
Self::MismatchedIdentityKeys(e)
}
}
impl From<SessionDeviceCheckError> for OlmError {
fn from(e: SessionDeviceCheckError) -> Self {
match e {
SessionDeviceCheckError::CryptoStoreError(e) => e.into(),
SessionDeviceCheckError::MismatchedIdentityKeys(e) => {
OlmError::SessionCreation(e.into())
}
}
}
}
impl From<SessionDeviceCheckError> for MegolmError {
fn from(e: SessionDeviceCheckError) -> Self {
match e {
SessionDeviceCheckError::CryptoStoreError(e) => e.into(),
SessionDeviceCheckError::MismatchedIdentityKeys(e) => e.into(),
}
}
}
#[derive(Debug)]
pub(crate) enum SessionDeviceKeysCheckError {
CryptoStoreError(CryptoStoreError),
MismatchedIdentityKeys(MismatchedIdentityKeysError),
SignatureError(SignatureError),
}
impl From<CryptoStoreError> for SessionDeviceKeysCheckError {
fn from(e: CryptoStoreError) -> Self {
Self::CryptoStoreError(e)
}
}
impl From<MismatchedIdentityKeysError> for SessionDeviceKeysCheckError {
fn from(e: MismatchedIdentityKeysError) -> Self {
Self::MismatchedIdentityKeys(e)
}
}
impl From<SignatureError> for SessionDeviceKeysCheckError {
fn from(e: SignatureError) -> Self {
Self::SignatureError(e)
}
}
impl From<SessionDeviceCheckError> for SessionDeviceKeysCheckError {
fn from(e: SessionDeviceCheckError) -> Self {
match e {
SessionDeviceCheckError::CryptoStoreError(e) => Self::CryptoStoreError(e),
SessionDeviceCheckError::MismatchedIdentityKeys(e) => Self::MismatchedIdentityKeys(e),
}
}
}
impl From<SessionDeviceKeysCheckError> for OlmError {
fn from(e: SessionDeviceKeysCheckError) -> Self {
match e {
SessionDeviceKeysCheckError::CryptoStoreError(e) => e.into(),
SessionDeviceKeysCheckError::MismatchedIdentityKeys(e) => {
OlmError::SessionCreation(e.into())
}
SessionDeviceKeysCheckError::SignatureError(e) => OlmError::SessionCreation(e.into()),
}
}
}
#[cfg(test)]
mod tests {
use std::{ops::Deref as _, sync::Arc};
use assert_matches2::assert_let;
use matrix_sdk_test::async_test;
use ruma::{device_id, room_id, user_id, DeviceId, OwnedUserId, RoomId, UserId};
use tokio::sync::Mutex;
use vodozemac::{megolm::SessionKey, Curve25519PublicKey, Ed25519PublicKey};
use super::SenderDataFinder;
use crate::{
error::MismatchedIdentityKeysError,
olm::{
group_sessions::sender_data_finder::SessionDeviceKeysCheckError, InboundGroupSession,
KnownSenderData, PrivateCrossSigningIdentity, SenderData,
},
store::{Changes, CryptoStoreWrapper, MemoryStore, Store},
types::{
events::{
olm_v1::DecryptedRoomKeyEvent,
room_key::{MegolmV1AesSha2Content, RoomKeyContent},
},
EventEncryptionAlgorithm,
},
verification::VerificationMachine,
Account, Device, DeviceData, OtherUserIdentityData, OwnUserIdentityData, UserIdentityData,
};
impl<'a> SenderDataFinder<'a> {
fn new(store: &'a Store, session: &'a InboundGroupSession) -> Self {
Self { store, session }
}
}
#[async_test]
async fn test_providing_no_device_data_returns_sender_data_with_no_device_info() {
// Given that the device is not in the store and the initial event has no device
// info
let setup = TestSetup::new(TestOptions::new()).await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back no useful information at all
assert_let!(SenderData::UnknownDevice { legacy_session, owner_check_failed } = sender_data);
assert!(!legacy_session);
assert!(!owner_check_failed);
}
#[async_test]
async fn test_if_the_todevice_event_contains_device_info_it_is_captured() {
// Given that the signed device keys are in the event
let setup =
TestSetup::new(TestOptions::new().device_is_signed().event_contains_device_keys())
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the device keys that were in the event
assert_let!(SenderData::DeviceInfo { device_keys, legacy_session } = sender_data);
assert_eq!(&device_keys, setup.sender_device.as_device_keys());
assert!(!legacy_session);
}
#[async_test]
async fn test_picks_up_device_info_from_the_store_if_missing_from_the_todevice_event() {
// Given that the device keys are not in the event but the device is in the
// store
let setup =
TestSetup::new(TestOptions::new().store_contains_device().device_is_signed()).await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the device keys that were in the store
assert_let!(SenderData::DeviceInfo { device_keys, legacy_session } = sender_data);
assert_eq!(&device_keys, setup.sender_device.as_device_keys());
assert!(!legacy_session);
}
#[async_test]
async fn test_adds_device_info_even_if_it_is_not_signed() {
// Given that the the device is in the store
// But it is not signed
let setup = TestSetup::new(TestOptions::new().store_contains_device()).await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we store the device info even though it is useless, in case we want to
// check it matches up later.
assert_let!(SenderData::DeviceInfo { device_keys, legacy_session } = sender_data);
assert_eq!(&device_keys, setup.sender_device.as_device_keys());
assert!(!legacy_session);
}
#[async_test]
async fn test_adds_sender_data_for_own_verified_device_and_user_using_device_from_store() {
// Given the device is in the store, and we sent the event
let setup = TestSetup::new(
TestOptions::new()
.store_contains_device()
.store_contains_sender_identity()
.device_is_signed()
.sender_is_ourself(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the information about the sender
assert_let!(
SenderData::SenderUnverified(KnownSenderData { user_id, device_id, master_key }) =
sender_data
);
assert_eq!(user_id, setup.sender.user_id);
assert_eq!(device_id.unwrap(), setup.sender_device.device_id());
assert_eq!(*master_key, setup.sender_master_key());
}
#[async_test]
async fn test_adds_sender_data_for_other_verified_device_and_user_using_device_from_store() {
// Given the device is in the store, and someone else sent the event
let setup = TestSetup::new(
TestOptions::new()
.store_contains_device()
.store_contains_sender_identity()
.device_is_signed(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the information about the sender
assert_let!(
SenderData::SenderUnverified(KnownSenderData { user_id, device_id, master_key }) =
sender_data
);
assert_eq!(user_id, setup.sender.user_id);
assert_eq!(device_id.unwrap(), setup.sender_device.device_id());
assert_eq!(*master_key, setup.sender_master_key());
}
#[async_test]
async fn test_adds_sender_data_for_own_device_and_user_using_device_from_event() {
// Given the device keys are in the event, and we sent the event
let setup = TestSetup::new(
TestOptions::new()
.store_contains_sender_identity()
.device_is_signed()
.event_contains_device_keys()
.sender_is_ourself(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the information about the sender
assert_let!(
SenderData::SenderUnverified(KnownSenderData { user_id, device_id, master_key }) =
sender_data
);
assert_eq!(user_id, setup.sender.user_id);
assert_eq!(device_id.unwrap(), setup.sender_device.device_id());
assert_eq!(*master_key, setup.sender_master_key());
}
#[async_test]
async fn test_adds_sender_data_for_other_verified_device_and_user_using_device_from_event() {
// Given the device keys are in the event, and someone else sent the event
let setup = TestSetup::new(
TestOptions::new()
.store_contains_sender_identity()
.device_is_signed()
.event_contains_device_keys(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the information about the sender
assert_let!(
SenderData::SenderUnverified(KnownSenderData { user_id, device_id, master_key }) =
sender_data
);
assert_eq!(user_id, setup.sender.user_id);
assert_eq!(device_id.unwrap(), setup.sender_device.device_id());
assert_eq!(*master_key, setup.sender_master_key());
}
#[async_test]
async fn test_if_session_signing_does_not_match_device_return_an_error() {
// Given everything is the same as the above test
// except the session is not owned by the device
let setup = TestSetup::new(
TestOptions::new()
.store_contains_sender_identity()
.device_is_signed()
.event_contains_device_keys()
.session_signing_key_differs_from_device(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
assert_let!(
Err(e) =
finder.have_event(setup.sender_device_curve_key(), &setup.room_key_event).await
);
assert_let!(SessionDeviceKeysCheckError::MismatchedIdentityKeys(e) = e);
let key_ed25519 =
Box::new(setup.session.signing_keys().iter().next().unwrap().1.ed25519().unwrap());
let key_curve25519 = Box::new(setup.session.sender_key());
let device_ed25519 = setup.sender_device.ed25519_key().map(Box::new);
let device_curve25519 = Some(Box::new(setup.sender_device_curve_key()));
assert_eq!(
e,
MismatchedIdentityKeysError {
key_ed25519,
device_ed25519,
key_curve25519,
device_curve25519
}
);
}
#[async_test]
async fn test_does_not_add_sender_data_for_a_device_missing_keys() {
// Given everything is the same as the successful test
// except the device does not own the session because
// it is imported.
let setup = TestSetup::new(
TestOptions::new()
.store_contains_sender_identity()
.session_is_imported()
.event_contains_device_keys(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we fail to find useful sender data
assert_let!(SenderData::UnknownDevice { legacy_session, owner_check_failed } = sender_data);
assert!(!legacy_session);
// And report that the owner_check_failed
assert!(owner_check_failed);
}
#[async_test]
async fn test_notes_master_key_is_verified_for_own_identity() {
// Given we can find the device, and we sent the event, and we are verified
let setup = TestSetup::new(
TestOptions::new()
.store_contains_device()
.store_contains_sender_identity()
.device_is_signed()
.event_contains_device_keys()
.sender_is_ourself()
.sender_is_verified(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the information about the sender
assert_let!(
SenderData::SenderVerified(KnownSenderData { user_id, device_id, master_key }) =
sender_data
);
assert_eq!(user_id, setup.sender.user_id);
assert_eq!(device_id.unwrap(), setup.sender_device.device_id());
assert_eq!(*master_key, setup.sender_master_key());
}
#[async_test]
async fn test_notes_master_key_is_verified_for_other_identity() {
// Given we can find the device, and someone else sent the event
// And the sender is verified
let setup = TestSetup::new(
TestOptions::new()
.store_contains_device()
.store_contains_sender_identity()
.device_is_signed()
.event_contains_device_keys()
.sender_is_verified(),
)
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we try to find sender data
let sender_data = finder
.have_event(setup.sender_device_curve_key(), &setup.room_key_event)
.await
.unwrap();
// Then we get back the information about the sender
assert_let!(
SenderData::SenderVerified(KnownSenderData { user_id, device_id, master_key }) =
sender_data
);
assert_eq!(user_id, setup.sender.user_id);
assert_eq!(device_id.unwrap(), setup.sender_device.device_id());
assert_eq!(*master_key, setup.sender_master_key());
}
#[async_test]
async fn test_can_add_user_sender_data_based_on_a_provided_device() {
// Given the device is not in the store or the event
let setup =
TestSetup::new(TestOptions::new().store_contains_sender_identity().device_is_signed())
.await;
let finder = SenderDataFinder::new(&setup.store, &setup.session);
// When we supply the device keys directly while asking for the sender data
let sender_data = finder.have_device_data(setup.sender_device.inner.clone()).await.unwrap();
// Then it is found using the device we supplied
assert_let!(
SenderData::SenderUnverified(KnownSenderData { user_id, device_id, master_key }) =
sender_data
);
assert_eq!(user_id, setup.sender.user_id);
assert_eq!(device_id.unwrap(), setup.sender_device.device_id());
assert_eq!(*master_key, setup.sender_master_key());
}
struct TestOptions {
store_contains_device: bool,
store_contains_sender_identity: bool,
device_is_signed: bool,
event_contains_device_keys: bool,
sender_is_ourself: bool,
sender_is_verified: bool,
session_signing_key_differs_from_device: bool,
session_is_imported: bool,
}
impl TestOptions {
fn new() -> Self {
Self {
store_contains_device: false,
store_contains_sender_identity: false,
device_is_signed: false,
event_contains_device_keys: false,
sender_is_ourself: false,
sender_is_verified: false,
session_signing_key_differs_from_device: false,
session_is_imported: false,
}
}
fn store_contains_device(mut self) -> Self {
self.store_contains_device = true;
self
}
fn store_contains_sender_identity(mut self) -> Self {
self.store_contains_sender_identity = true;
self
}
fn device_is_signed(mut self) -> Self {
self.device_is_signed = true;
self
}
fn event_contains_device_keys(mut self) -> Self {
self.event_contains_device_keys = true;
self
}
fn sender_is_ourself(mut self) -> Self {
self.sender_is_ourself = true;
self
}
fn sender_is_verified(mut self) -> Self {
self.sender_is_verified = true;
self
}
fn session_signing_key_differs_from_device(mut self) -> Self {
self.session_signing_key_differs_from_device = true;
self
}
fn session_is_imported(mut self) -> Self {
self.session_is_imported = true;
self
}
}
struct TestSetup {
sender: TestUser,
sender_device: Device,
store: Store,
room_key_event: DecryptedRoomKeyEvent,
session: InboundGroupSession,
}
impl TestSetup {
async fn new(options: TestOptions) -> Self {
let me = TestUser::own().await;
let sender = TestUser::other(&me, &options).await;
let sender_device = if options.device_is_signed {
create_signed_device(&sender.account, &*sender.private_identity.lock().await).await
} else {
create_unsigned_device(&sender.account)
};
let store = create_store(&me);
save_to_store(&store, &me, &sender, &sender_device, &options).await;
let room_id = room_id!("!r:s.co");
let session_key = create_session_key();
let room_key_event = create_room_key_event(
&sender.user_id,
&me.user_id,
&sender_device,
room_id,
&session_key,
&options,
);
let signing_key = if options.session_signing_key_differs_from_device {
Ed25519PublicKey::from_base64("2/5LWJMow5zhJqakV88SIc7q/1pa8fmkfgAzx72w9G4")
.unwrap()
} else {
sender_device.inner.ed25519_key().unwrap()
};
let mut session = InboundGroupSession::new(
sender_device.inner.curve25519_key().unwrap(),
signing_key,
room_id,
&session_key,
SenderData::unknown(),
EventEncryptionAlgorithm::MegolmV1AesSha2,
None,
)
.unwrap();
if options.session_is_imported {
session.mark_as_imported();
}
Self { sender, sender_device, store, room_key_event, session }
}
fn sender_device_curve_key(&self) -> Curve25519PublicKey {
self.sender_device.curve25519_key().unwrap()
}
fn sender_master_key(&self) -> Ed25519PublicKey {
self.sender.user_identity.master_key().get_first_key().unwrap()
}
}
fn create_store(me: &TestUser) -> Store {
let store_wrapper = Arc::new(CryptoStoreWrapper::new(
&me.user_id,
me.account.device_id(),
MemoryStore::new(),
));
let verification_machine = VerificationMachine::new(
me.account.deref().clone(),
Arc::clone(&me.private_identity),
Arc::clone(&store_wrapper),
);
Store::new(
me.account.static_data.clone(),
Arc::clone(&me.private_identity),
store_wrapper,
verification_machine,
)
}
async fn save_to_store(
store: &Store,
me: &TestUser,
sender: &TestUser,
sender_device: &Device,
options: &TestOptions,
) {
let mut changes = Changes::default();
// If the device should exist in the store, add it
if options.store_contains_device {
changes.devices.new.push(sender_device.inner.clone())
}
// Add the sender identity to the store
if options.store_contains_sender_identity {
changes.identities.new.push(sender.user_identity.clone());
}
// If it's different from the sender, add our identity too
if !options.sender_is_ourself {
changes.identities.new.push(me.user_identity.clone());
}
store.save_changes(changes).await.unwrap();
}
struct TestUser {
user_id: OwnedUserId,
account: Account,
private_identity: Arc<Mutex<PrivateCrossSigningIdentity>>,
user_identity: UserIdentityData,
}
impl TestUser {
async fn new(
user_id: &UserId,
device_id: &DeviceId,
is_me: bool,
is_verified: bool,
signer: Option<&TestUser>,
) -> Self {
let account = Account::with_device_id(user_id, device_id);
let user_id = user_id.to_owned();
let private_identity = Arc::new(Mutex::new(create_private_identity(&account).await));
let user_identity =
create_user_identity(&*private_identity.lock().await, is_me, is_verified, signer)
.await;
Self { user_id, account, private_identity, user_identity }
}
async fn own() -> Self {
Self::new(user_id!("@myself:s.co"), device_id!("OWNDEVICEID"), true, true, None).await
}
async fn other(me: &TestUser, options: &TestOptions) -> Self {
let user_id =
if options.sender_is_ourself { &me.user_id } else { user_id!("@other:s.co") };
Self::new(
user_id,
device_id!("SENDERDEVICEID"),
options.sender_is_ourself,
options.sender_is_verified,
Some(me),
)
.await
}
}
async fn create_user_identity(
private_identity: &PrivateCrossSigningIdentity,
is_me: bool,
is_verified: bool,
signer: Option<&TestUser>,
) -> UserIdentityData {
if is_me {
let own_user_identity = OwnUserIdentityData::from_private(private_identity).await;
if is_verified {
own_user_identity.mark_as_verified();
}
UserIdentityData::Own(own_user_identity)
} else {
let mut other_user_identity =
OtherUserIdentityData::from_private(private_identity).await;
if is_verified {
sign_other_identity(signer, &mut other_user_identity).await;
}
UserIdentityData::Other(other_user_identity)
}
}
async fn sign_other_identity(
signer: Option<&TestUser>,
other_user_identity: &mut OtherUserIdentityData,
) {
if let Some(signer) = signer {
let signer_private_identity = signer.private_identity.lock().await;
let user_signing = signer_private_identity.user_signing_key.lock().await;
let user_signing = user_signing.as_ref().unwrap();
let master = user_signing.sign_user(&*other_user_identity).unwrap();
other_user_identity.master_key = Arc::new(master.try_into().unwrap());
user_signing.public_key().verify_master_key(other_user_identity.master_key()).unwrap();
} else {
panic!("You must provide a `signer` if you want an Other to be verified!");
}
}
async fn create_private_identity(account: &Account) -> PrivateCrossSigningIdentity {
PrivateCrossSigningIdentity::with_account(account).await.0
}
async fn create_signed_device(
account: &Account,
private_identity: &PrivateCrossSigningIdentity,
) -> Device {
let mut read_only_device = DeviceData::from_account(account);
let self_signing = private_identity.self_signing_key.lock().await;
let self_signing = self_signing.as_ref().unwrap();
let mut device_keys = read_only_device.as_device_keys().to_owned();
self_signing.sign_device(&mut device_keys).unwrap();
read_only_device.update_device(&device_keys).unwrap();
wrap_device(account, read_only_device)
}
fn create_unsigned_device(account: &Account) -> Device {
wrap_device(account, DeviceData::from_account(account))
}
fn wrap_device(account: &Account, read_only_device: DeviceData) -> Device {
Device {
inner: read_only_device,
verification_machine: VerificationMachine::new(
account.deref().clone(),
Arc::new(Mutex::new(PrivateCrossSigningIdentity::new(
account.user_id().to_owned(),
))),
Arc::new(CryptoStoreWrapper::new(
account.user_id(),
account.device_id(),
MemoryStore::new(),
)),
),
own_identity: None,
device_owner_identity: None,
}
}
fn create_room_key_event(
sender: &UserId,
receiver: &UserId,
sender_device: &Device,
room_id: &RoomId,
session_key: &SessionKey,
options: &TestOptions,
) -> DecryptedRoomKeyEvent {
let device = if options.event_contains_device_keys {
Some(sender_device.as_device_keys().clone())
} else {
None
};
DecryptedRoomKeyEvent::new(
sender,
receiver,
Ed25519PublicKey::from_base64("loz5i40dP+azDtWvsD0L/xpnCjNkmrcvtXVXzCHX8Vw").unwrap(),
device,
RoomKeyContent::MegolmV1AesSha2(Box::new(MegolmV1AesSha2Content::new(
room_id.to_owned(),
"mysession".to_owned(),
clone_session_key(session_key),
))),
)
}
fn create_session_key() -> SessionKey {
SessionKey::from_base64(
"\
AgAAAADBy9+YIYTIqBjFT67nyi31gIOypZQl8day2hkhRDCZaHoG+cZh4tZLQIAZimJail0\
0zq4DVJVljO6cZ2t8kIto/QVk+7p20Fcf2nvqZyL2ZCda2Ei7VsqWZHTM/gqa2IU9+ktkwz\
+KFhENnHvDhG9f+hjsAPZd5mTTpdO+tVcqtdWhX4dymaJ/2UpAAjuPXQW+nXhQWQhXgXOUa\
JCYurJtvbCbqZGeDMmVIoqukBs2KugNJ6j5WlTPoeFnMl6Guy9uH2iWWxGg8ZgT2xspqVl5\
CwujjC+m7Dh1toVkvu+bAw\
",
)
.unwrap()
}
fn clone_session_key(session_key: &SessionKey) -> SessionKey {
SessionKey::from_base64(&session_key.to_base64()).unwrap()
}
}