1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
// Copyright 2021 The Matrix.org Foundation C.I.C.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//! Types for the [Proof Key for Code Exchange].
//!
//! [Proof Key for Code Exchange]: https://www.rfc-editor.org/rfc/rfc7636
use std::borrow::Cow;
use data_encoding::BASE64URL_NOPAD;
use mas_iana::oauth::PkceCodeChallengeMethod;
use serde::{Deserialize, Serialize};
use sha2::{Digest, Sha256};
use thiserror::Error;
/// Errors that can occur when verifying a code challenge.
#[derive(Debug, Error, PartialEq, Eq)]
pub enum CodeChallengeError {
/// The code verifier should be at least 43 characters long.
#[error("code_verifier should be at least 43 characters long")]
TooShort,
/// The code verifier should be at most 128 characters long.
#[error("code_verifier should be at most 128 characters long")]
TooLong,
/// The code verifier contains invalid characters.
#[error("code_verifier contains invalid characters")]
InvalidCharacters,
/// The challenge verification failed.
#[error("challenge verification failed")]
VerificationFailed,
/// The challenge method is unsupported.
#[error("unknown challenge method")]
UnknownChallengeMethod,
}
fn validate_verifier(verifier: &str) -> Result<(), CodeChallengeError> {
if verifier.len() < 43 {
return Err(CodeChallengeError::TooShort);
}
if verifier.len() > 128 {
return Err(CodeChallengeError::TooLong);
}
if !verifier
.chars()
.all(|c| c.is_ascii_alphanumeric() || c == '-' || c == '.' || c == '_' || c == '~')
{
return Err(CodeChallengeError::InvalidCharacters);
}
Ok(())
}
/// Helper trait to compute and verify code challenges.
pub trait CodeChallengeMethodExt {
/// Compute the challenge for a given verifier
///
/// # Errors
///
/// Returns an error if the verifier did not adhere to the rules defined by
/// the RFC in terms of length and allowed characters
fn compute_challenge<'a>(&self, verifier: &'a str) -> Result<Cow<'a, str>, CodeChallengeError>;
/// Verify that a given verifier is valid for the given challenge
///
/// # Errors
///
/// Returns an error if the verifier did not match the challenge, or if the
/// verifier did not adhere to the rules defined by the RFC in terms of
/// length and allowed characters
fn verify(&self, challenge: &str, verifier: &str) -> Result<(), CodeChallengeError>
where
Self: Sized,
{
if self.compute_challenge(verifier)? == challenge {
Ok(())
} else {
Err(CodeChallengeError::VerificationFailed)
}
}
}
impl CodeChallengeMethodExt for PkceCodeChallengeMethod {
fn compute_challenge<'a>(&self, verifier: &'a str) -> Result<Cow<'a, str>, CodeChallengeError> {
validate_verifier(verifier)?;
let challenge = match self {
Self::Plain => verifier.into(),
Self::S256 => {
let mut hasher = Sha256::new();
hasher.update(verifier.as_bytes());
let hash = hasher.finalize();
let verifier = BASE64URL_NOPAD.encode(&hash);
verifier.into()
}
_ => return Err(CodeChallengeError::UnknownChallengeMethod),
};
Ok(challenge)
}
}
/// The code challenge data added to an authorization request.
#[derive(Clone, Serialize, Deserialize)]
pub struct AuthorizationRequest {
/// The code challenge method.
pub code_challenge_method: PkceCodeChallengeMethod,
/// The code challenge computed from the verifier and the method.
pub code_challenge: String,
}
/// The code challenge data added to a token request.
#[derive(Clone, Serialize, Deserialize)]
pub struct TokenRequest {
/// The code challenge verifier.
pub code_challenge_verifier: String,
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_pkce_verification() {
use PkceCodeChallengeMethod::{Plain, S256};
// This challenge comes from the RFC7636 appendices
let challenge = "E9Melhoa2OwvFrEMTJguCHaoeK1t8URWbuGJSstw-cM";
assert!(S256
.verify(challenge, "dBjftJeZ4CVP-mB92K27uhbUJU1p1r_wW1gFWFOEjXk")
.is_ok());
assert!(Plain.verify(challenge, challenge).is_ok());
assert_eq!(
S256.verify(challenge, "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"),
Err(CodeChallengeError::VerificationFailed),
);
assert_eq!(
S256.verify(challenge, "tooshort"),
Err(CodeChallengeError::TooShort),
);
assert_eq!(
S256.verify(challenge, "toolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolongtoolong"),
Err(CodeChallengeError::TooLong),
);
assert_eq!(
S256.verify(
challenge,
"this is long enough but has invalid characters in it"
),
Err(CodeChallengeError::InvalidCharacters),
);
}
}